openvinotoolkit / training_extensions

Train, Evaluate, Optimize, Deploy Computer Vision Models via OpenVINO™
https://openvinotoolkit.github.io/training_extensions/
Apache License 2.0
1.14k stars 443 forks source link

Merge back 2.2 #4098

Closed kprokofi closed 1 week ago

kprokofi commented 2 weeks ago

Summary

How to test

Checklist

License

# Copyright (C) 2024 Intel Corporation
# SPDX-License-Identifier: Apache-2.0
codecov[bot] commented 2 weeks ago

Codecov Report

Attention: Patch coverage is 81.53846% with 12 lines in your changes missing coverage. Please review.

Project coverage is 80.42%. Comparing base (31823cd) to head (2c99adb). Report is 38 commits behind head on develop.

Files with missing lines Patch % Lines
.../algo/detection/detectors/detection_transformer.py 57.14% 3 Missing :warning:
src/otx/core/data/dataset/base.py 85.71% 3 Missing :warning:
src/otx/core/data/dataset/classification.py 75.00% 2 Missing :warning:
src/otx/core/model/keypoint_detection.py 80.00% 2 Missing :warning:
src/otx/core/data/dataset/diffusion.py 0.00% 1 Missing :warning:
src/otx/core/data/dataset/segmentation.py 83.33% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #4098 +/- ## =========================================== + Coverage 77.11% 80.42% +3.30% =========================================== Files 308 319 +11 Lines 30571 31645 +1074 =========================================== + Hits 23576 25450 +1874 + Misses 6995 6195 -800 ``` | [Flag](https://app.codecov.io/gh/openvinotoolkit/training_extensions/pull/4098/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openvinotoolkit) | Coverage Δ | | |---|---|---| | [py310](https://app.codecov.io/gh/openvinotoolkit/training_extensions/pull/4098/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openvinotoolkit) | `80.39% <81.53%> (+3.28%)` | :arrow_up: | | [py311](https://app.codecov.io/gh/openvinotoolkit/training_extensions/pull/4098/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openvinotoolkit) | `80.35% <81.53%> (+3.30%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openvinotoolkit#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

kprokofi commented 2 weeks ago

I will update this PR after RC14 will be finalized

eugene123tw commented 1 week ago

@kprokofi Could you add a line to src/otx/core/data/transform_libs/torchvision.py image This should fix the index error.

sovrasov commented 1 week ago

Now the failure is:

setattr(inputs, key, attr[keep])
IndexError: boolean index did not match indexed array along dimension 0; dimension is 3 but corresponding boolean dimension is 2

@kprokofi could you disable the failing RTMDet test? We should keep in mind that the model is dysfunctional for now

eugene123tw commented 1 week ago

Now the failure is:

setattr(inputs, key, attr[keep])
IndexError: boolean index did not match indexed array along dimension 0; dimension is 3 but corresponding boolean dimension is 2

@kprokofi could you disable the failing RTMDet test? We should keep in mind that the model is dysfunctional for now

@sovrasov @kprokofi yeah, that's disable inst seg recipes for now. I think there's some bug in FilterAnnotations. I will open a PR to fix it.