openvolley / ovscout2

An R Shiny app for scouting volleyball data files
https://ovscout2.openvolley.org
Other
5 stars 1 forks source link

Progressive lag between mouse click and popup appearance #18

Closed mchiapello closed 1 year ago

mchiapello commented 1 year ago

Hi, I noticed that after the second set scout ovscout2 becomes very slow. There is a progressive lag between the mouse click and the popup appearance.

Is there something I can do?

raymondben commented 1 year ago

We haven't noticed this behavior, so I'll watch for it next time I am scouting a match. The lag here will be more noticeable with a less powerful computer (we should see if we can optimize the reactive flow to make this faster) but I am not sure why it would get worse as you scout more of the match.

mchiapello commented 1 year ago

I am scouting on a MacBook Pro (16-inch, 2021) with Apple M1 Pro and 16Gb of memory. I am launching the app from the last version of RStudio.

R version 4.2.1 (2022-06-23)
Platform: x86_64-apple-darwin17.0 (64-bit)
Running under: macOS Monterey 12.3

Matrix products: default
LAPACK: /Library/Frameworks/R.framework/Versions/4.2/Resources/lib/libRlapack.dylib

locale:
[1] en_US.UTF-8/en_US.UTF-8/en_US.UTF-8/C/en_US.UTF-8/en_US.UTF-8

attached base packages:
[1] stats     graphics  grDevices utils     datasets  methods   base     

other attached packages:
 [1] lubridate_1.9.0  timechange_0.1.1 shiny_1.7.3      here_1.0.1       fs_1.5.2         forcats_0.5.2   
 [7] stringr_1.4.1    dplyr_1.0.10     purrr_0.3.5      readr_2.1.3      tidyr_1.2.1      tibble_3.1.8    
[13] ggplot2_3.4.0    tidyverse_1.3.2  ovscout2_0.1.4   datavolley_1.3.4

loaded via a namespace (and not attached):
  [1] websocket_1.4.1     googledrive_2.0.0   colorspace_2.0-3    ellipsis_0.3.2      rsconnect_0.8.28   
  [6] rprojroot_2.0.3     snakecase_0.11.0    rstudioapi_0.14     farver_2.1.1        DT_0.26            
 [11] bit64_4.0.5         chromote_0.1.1      fansi_1.0.3         xml2_1.3.3          R.methodsS3_1.8.2  
 [16] cachem_1.0.6        knitr_1.40          shinythemes_1.2.0   jsonlite_1.8.3      gt_0.7.0           
 [21] broom_1.0.1         dbplyr_2.2.1        R.oo_1.25.0         compiler_4.2.1      httr_1.4.4         
 [26] quarto_1.2          backports_1.4.1     assertthat_0.2.1    fastmap_1.1.0       gargle_1.2.1       
 [31] cli_3.4.1           later_1.3.0         htmltools_0.5.3     tools_4.2.1         gtable_0.3.1       
 [36] glue_1.6.2          rappdirs_0.3.3      Rcpp_1.0.9          cellranger_1.1.0    jquerylib_0.1.4    
 [41] vctrs_0.5.0         av_0.8.2            gtExtras_0.4.2      rintrojs_0.3.2      crosstalk_1.2.0    
 [46] xfun_0.34           ps_1.7.2            rvest_1.0.3         mime_0.12           lifecycle_1.0.3    
 [51] sys_3.4.1           googlesheets4_1.0.1 scales_1.2.1        vroom_1.6.0         ragg_1.2.4         
 [56] hms_1.1.2           promises_1.2.0.1    parallel_4.2.1      rematch2_2.1.2      yaml_2.3.6         
 [61] memoise_2.0.1       sass_0.4.2          stringi_1.7.8       paletteer_1.5.0     commonmark_1.8.1   
 [66] rlang_1.0.6         pkgconfig_2.0.3     systemfonts_1.0.4   evaluate_0.17       archive_1.1.5      
 [71] fontawesome_0.4.0   patchwork_1.1.2     htmlwidgets_1.5.4   labeling_0.4.2      processx_3.8.0     
 [76] bit_4.0.4           tidyselect_1.2.0    plyr_1.8.7          magrittr_2.0.3      R6_2.5.1           
 [81] generics_0.1.3      DBI_1.1.3           pillar_1.8.1        haven_2.5.1         withr_2.5.0        
 [86] janitor_2.1.0       modelr_0.1.9        crayon_1.5.2        shinyWidgets_0.7.4  ovideo_0.19.0      
 [91] uuid_1.1-0          utf8_1.2.2          webshot2_0.1.0      tzdb_0.3.0          rmarkdown_2.17     
 [96] jpeg_0.1-9          grid_4.2.1          readxl_1.4.1        data.table_1.14.4   reprex_2.0.2       
[101] digest_0.6.30       xtable_1.8-4        httpuv_1.6.6        R.utils_2.12.1      textshaping_0.3.6  
[106] munsell_0.5.0       bslib_0.4.1 

Is there something that I can do to diminish the lag effect in your opinion?

raymondben commented 1 year ago

@mchiapello I just pushed a small change to the dev branch (https://github.com/openvolley/ovscout2/commit/35da660b0423fff44542935c7a34de7d54a3006c) that prioritizes the handling of click events. Would you mind testing when it's convenient and see if it made any difference? It seems to help on my machine ...