openvpi / DiffSinger

An advanced singing voice synthesis system with high fidelity, expressiveness, controllability and flexibility based on DiffSinger: Singing Voice Synthesis via Shallow Diffusion Mechanism
Apache License 2.0
2.69k stars 283 forks source link

Refactor to support PyTorch 2.0 and Lightning 2.0 #72

Closed hrukalive closed 1 year ago

hrukalive commented 1 year ago

新参数说明:


New parameter explanation:

yqzhishen commented 1 year ago

I formerly wrote a Python program calling git grep to search for config keys that are never used in other codes: search_config2.txt (renamed to .txt because GitHub does not support uploading .py files). You can use it to clean unused config keys after refactoring.

yqzhishen commented 1 year ago

This PR is ready to be merged after the final fixes and some simple tests on the incoming branch.

By the way, license of the refactor-v2 branch was formerly changed to Apache 2.0, which will be the new license of our forked DiffSinger once refactor-v2 is merged into the main branch. With your agreement, your contributions will also be licensed under Apache 2.0 in this repository.

hrukalive commented 1 year ago

My consent, thanks.

yqzhishen commented 1 year ago

Due to some unresolved performance issues during tests, this branch will be merged into a temporary branch. It should be merged into the main branch after these issues are addressed.

hrukalive commented 1 year ago

Performance is tightly linked to the grid resolution when performing shuffling and sorting by similar lengths on samples. When fully sorted, the performance does not drop compared to the original codebase.

yqzhishen commented 1 year ago

Performance issues addressed so I changed the base branch back to refactor-v2.