Problem description

Got 'local variable 'osd' referenced before assignment' when invoking ovs remove node.

Possible root of the problem

There weren't any ASDs claimed for the back-end. Perhaps there is no check on the existence of ASDs?

Possible solution

Add a check.

Temporary solution

None

Additional information

Happend on the remove hook: Stacktracing:

Demote complete

Removing node from model

\++\+ Running "remove" hooks \++\+

\++++++++++++++++++++++++++++++++++++++++++++++++++++++++++\+

\++\+  An unexpected error occurred:                      \++\+

\++\+  local variable 'osd' referenced before assignment  \++\+

\++++++++++++++++++++++++++++++++++++++++++++++++++++++++++\+

root@ovs-node1:~#

root@ovs-node1:~# less /var/log/ovs/lib.log

2016-08-10 11:41:25 83200 \+0200 - ovs-node1 - 3571/140406494132032 - lib/setup - 188 - INFO -

2016-08-10 11:41:25 83300 \+0200 - ovs-node1 - 3571/140406494132032 - lib/setup - 189 - ERROR - An unexpected error occurred:

Traceback (most recent call last):

File "ovs/lib/setup.py", line 703, in remove_nodes

SetupController._run_hooks('remove', storage_router.ip)

File "ovs/lib/setup.py", line 1653, in \_run_hooks

function(cluster_ip=cluster_ip, \**kwargs)

File "ovs/lib/helpers/..//albacontroller.py", line 713, in on_remove

AlbaNodeController.remove_disk(node_guid=osd.alba_disk.alba_node_guid, disk=osd.alba_disk.name)

UnboundLocalError: local variable 'osd' referenced before assignment

2016-08-10 11:41:25 83300 \+0200 - ovs-node1 - 3571/140406494132032 - lib/setup - 190 - ERROR - local variable 'osd' referenced before assignment

Traceback (most recent call last):

File "ovs/lib/setup.py", line 703, in remove_nodes

SetupController._run_hooks('remove', storage_router.ip)

File "ovs/lib/setup.py", line 1653, in \_run_hooks

function(cluster_ip=cluster_ip, \**kwargs)

File "ovs/lib/helpers/..//albacontroller.py", line 713, in on_remove

AlbaNodeController.remove_disk(node_guid=osd.alba_disk.alba_node_guid, disk=osd.alba_disk.name)

UnboundLocalError: local variable 'osd' referenced before assignment

Setup

Hyperconverged setup

Three nodes with each three disks for the back-end Ran test twice:
All disks on the node were initialized but not claimed.
Disks for the node to remove were not claimed
Package information
ii openvstorage 2.7.1-fargo.2-1 amd64 openvStorage
ii openvstorage-backend 1.7.1-fargo.1-1 amd64 openvStorage Backend plugin
ii openvstorage-backend-core 1.7.1-fargo.1-1 amd64 openvStorage Backend plugin core
ii openvstorage-backend-webapps 1.7.1-fargo.1-1 amd64 openvStorage Backend plugin Web Applications
ii openvstorage-cinder-plugin 1.2.1-fargo.1-1 amd64 OpenvStorage Cinder plugin for OpenStack
ii openvstorage-core 2.7.1-fargo.2-1 amd64 openvStorage core
ii openvstorage-hc 1.7.1-fargo.1-1 amd64 openvStorage Backend plugin HyperConverged
ii openvstorage-sdm 1.6.1-fargo.1-1 amd64 Open vStorage Backend ASD Manager
ii openvstorage-test 2.7.1-fargo.2-1 amd64 openvStorage autotest suite
ii openvstorage-webapps 2.7.1-fargo.2-1 amd64 openvStorage Web Applications

Copied from original issue: openvstorage/framework#797

khenderick commented 8 years ago

Fixed by #184 in openvstorage-backend-1.7.2-rev.672.249a91a

JeffreyDevloo commented 8 years ago

Verified, could no longer reproduce the issue using the same setup.

openvstorage / framework-alba-plugin

Remove node: local variable 'osd' referenced before assignment #183