openvstorage / framework-alba-plugin

The Framework ALBA plugin extends the OpenvStorage GUI with functionality to manage ASDs (Alternate Storage Daemon) and Seagate Kinetic drives.
Other
2 stars 3 forks source link

Set fragment size to 16MB by default instead of 1MB #237

Closed wimpers closed 7 years ago

wimpers commented 7 years ago

Set fragment size to 16MB by default instead of 1MB.

khenderick commented 7 years ago

Fixed by #242, packaged in openvstorage-backend-1.7.4-rev.764.b87b3c9

JeffreyDevloo commented 7 years ago

Steps

Code to verify:

from ovs.dal.lists.albabackendlist import AlbaBackendList

faulted_backends = {}
expected_value = 16 * 1024 ** 2

for albabackend in AlbaBackendList.get_albabackends():
    for preset in albabackend.presets:

        if preset['fragment_size'] != expected_value:
            faulted_backends[albabackend.name] = {preset['name']:preset['fragment_size']}
        else:
            print 'Fragment size is right for preset {0} and albabackend {1}'.format(preset['name'], albabackend.name)

if len(faulted_backends.keys()) > 0:
    raise ValueError('Fragment sizes are not 16MB by default for presets {0} on backends {1}'.format(''.join(str(faulted_backends.values())), ''.join(faulted_backends.keys())))

Output

Fragment size is right for preset testpreset and albabackend mybackend
---------------------------------------------------------------------------
ValueError                                Traceback (most recent call last)
<ipython-input-3-116d80034f59> in <module>()
     13 
     14 if len(faulted_backends.keys()) > 0:
---> 15     raise ValueError('Fragment sizes are not 16MB by default for presets {0} on backends {1}'.format(''.join(str(faulted_backends.values())), ''.join(faulted_backends.keys())))

ValueError: Fragment sizes are not 16MB by default for presets [{'default': 1048576}] on backends mybackend

The fragmentsize for the default preset is still 1MB

Test result

Test failed.

Packages

JeffreyDevloo commented 7 years ago

Information

The framework code works as intended. The reason why the test initially failed was due to the default preset shipped by Alba therefore this issue has been resolved. Opened a ticket on their side https://github.com/openvstorage/alba/issues/410.

Test result

Test passed.

wimpers commented 7 years ago

The decision was to have the framework set the default of 16MB when creating the backend. The ALBA default did not have to be updated.