search

openvstorage / framework-alba-plugin

The Framework ALBA plugin extends the OpenvStorage GUI with functionality to manage ASDs (Alternate Storage Daemon) and Seagate Kinetic drives.
Other
2 stars 3 forks source link

ASDs which don't belong to the backend should not be labelled green but grey #545

Closed JeffreyDevloo closed 6 years ago

JeffreyDevloo commented 6 years ago

From @wimpers on September 21, 2017 13:59

ASDs which don't belong to the backend should not be labelled green but grey.

2017-09-21_15-56-42

Copied from original issue: openvstorage/framework#1782

JeffreyDevloo commented 6 years ago

The gray color is used for marking osds that we know nothing about (unable to query to information) Should we still mark it as gray? Also this is for the current development build, not yet released so we should tackle this quite quickly

JeffreyDevloo commented 6 years ago

From @wimpers on September 21, 2017 14:4

Yes, please as having them being green should only be used for disks which belong to that backend

JeffreyDevloo commented 6 years ago

From @kvanhijf on September 21, 2017 14:12

We should be able to distinguish the difference between grey disks belonging to the current Backend (for whatever reaons they are grye) and grey disks belonging to another Backend, no?

On Thu, Sep 21, 2017 at 4:07 PM Wim Provoost notifications@github.com wrote:

Yes, please as having them being green should only be used for disks which belong to that backend

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/openvstorage/framework/issues/1782#issuecomment-331166375, or mute the thread https://github.com/notifications/unsubscribe-auth/AM6JZs03xo3b9fCQRkLabrSrvfdju5Wkks5skmzSgaJpZM4PfXSQ .

JeffreyDevloo commented 6 years ago

From @wimpers on December 4, 2017 11:16

It would be best if we can make the distinction (2 types of gray, also do it it on the node detail if you expand).

Before starting with this best solution, can we estimate the simple solution (just adding the ASDs which don't belong to the backend to grey/unknown) and the best solution?

JeffreyDevloo commented 6 years ago

@wimpers I estimate it to be 2 hours of work

The detail view already shows these osds as 'unavailable' and gray We just need to differentiate from backend which won't take that long

JeffreyDevloo commented 6 years ago

Would be implemented by https://github.com/openvstorage/framework-alba-plugin/pull/546

JeffreyDevloo commented 6 years ago

Fixed by #546

JeffreyDevloo commented 6 years ago

Part of the https://github.com/openvstorage/framework-alba-plugin/releases/tag/1.11.0 release