NBD devices created for iSCSI can be used for ALBA

openvstorage / framework-alba-plugin

The Framework ALBA plugin extends the OpenvStorage GUI with functionality to manage ASDs (Alternate Storage Daemon) and Seagate Kinetic drives.

Other

2 stars 3 forks source link

NBD devices created for iSCSI can be used for ALBA #588

Closed wimpers closed 6 years ago

wimpers commented 6 years ago

NBD devices created by us for iSCSI can be used for ALBA, this should not be possible.

JeffreyDevloo commented 6 years ago

Infinite storage cycle? :+1:

wimpers commented 6 years ago

As long as you don't write you are safe :)

wimpers commented 6 years ago

I'm wondering if we don't need to be more clever about this an revisit our strategy:

we keep on bumping into disks which should not be shown or are not shown
Amazon EBS disks don't work all together

JeffreyDevloo commented 6 years ago

We process the disks that the OS can see. Certain types of drive are ignored already, however we cannot be up to date with all the new hot and flashy stuff...

wimpers commented 6 years ago

After discussion with the framework team:

I this ticket we will do a quick fix by out all NBD disks.
A feature request should be created to handle this more intelligent (f.e. option to show all block devices, custom filtering).

sjovdnbos commented 6 years ago

Fixed by:

https://github.com/openvstorage/alba-asdmanager/pull/328 https://github.com/openvstorage/framework/pull/2045

Package information:

openvstorage-sdm-1.12.0-dev.1525766055.afbcbab openvstorage-2.12.0-dev.1525766640.0f877cf

JeffreyDevloo commented 6 years ago

Released in https://github.com/openvstorage/framework-alba-plugin/releases/tag/1.12.0 Packaged in openvstorage-backend-core_1.12.0-1_amd64.deb