Configuration: add typing information to avoid client knowing if its raw or not

openvstorage / framework

The Framework is a set of components and tools which brings the user an interface (GUI / API) to setup, extend and manage an Open vStorage platform.

Other

27 stars 23 forks source link

Configuration: add typing information to avoid client knowing if its raw or not #2230

Open JeffreyDevloo opened 5 years ago

JeffreyDevloo commented 5 years ago

Possible solutions:

add item suffix (easiest)
add metdata key with type (requires managing two keys)
Wrap in json always with key being type, value being the thing to save (least performant)

All of them require update code once implemented

toolslive commented 5 years ago

I interpret the first solution as "suffix the value" and then there's an alternative in suffixing a type marker in the key.

sjovdnbos commented 5 years ago

I have been attempting to implement the suffix-value method, A major drawback of this method is that the content of a config json is not easily changeable anymore, for example via ovs config get. This could be circumvented by adding some more functionality in the CLI that adapts the config in place for readability. This ofcourse implies some loss of performance (which is the whole point of this ticket.

sjovdnbos commented 5 years ago

Fixed by:

https://github.com/openvstorage/framework/pull/2240 openvstorage-2.13.5-dev.1547566044.24f9650 https://github.com/openvstorage/alba-asdmanager/pull/359 openvstorage-sdm-1.13.3-dev.1547471285.01ead9f https://github.com/openvstorage/framework-extensions/pull/200: package information: openvstorage-extensions-0.5.3-dev.1547563500.a480de7 https://github.com/openvstorage/framework-alba-plugin/pull/631 openvstorage-backend-1.13.3-dev.1547570596.07616e5