Closed jfoug closed 8 years ago
289dcef fixes all of the dyna_num % 4 formats (and probably others). We had a quick check for hex, that was using element [0] and NOT the element for this thread.
I still have these to look into. They can NOT be run in OMP builds, and I thought I had that worked out at one time. It may be this was the 'work around', to simply fail the ST, and not allow the format to run, I really do not remember.
$ ../run/john -test=0 -form=dynamic | grep -v PASS
Will run 8 OpenMP threads
Testing: dynamic_22 [md5(sha1($p)) 128/128 AVX 4x1]... FAILED (FMT_OMP_BAD)
Testing: dynamic_23 [sha1(md5($p)) 128/128 AVX 4x1]... FAILED (FMT_OMP_BAD)
Testing: dynamic_1018 [md5(sha1(sha1($p))) 128/128 AVX 4x1]... FAILED (FMT_OMP_BAD)
Testing: dynamic_1019 [md5(sha1(sha1(md5($p)))) 128/128 AVX 4x1]... FAILED (FMT_OMP_BAD)
Testing: dynamic_1020 [md5(sha1(md5($p))) 128/128 AVX 4x1]... FAILED (FMT_OMP_BAD)
Testing: dynamic_1021 [md5(sha1(md5(sha1($p)))) 128/128 AVX 4x1]... FAILED (FMT_OMP_BAD)
Testing: dynamic_1022 [md5(sha1(md5(sha1(md5($p))))) 128/128 AVX 4x1]... FAILED (FMT_OMP_BAD)
Testing: dynamic_1024 [sha1(md5($p)) (hash truncated to length 32) 128/128 AVX 4x1]... FAILED (FMT_OMP_BAD)
Testing: dynamic_1025 [sha1(md5(md5($p))) (hash truncated to length 32) 128/128 AVX 4x1]... FAILED (FMT_OMP_BAD)
9 out of 445 tests have FAILED
The problem comes from SIMD builds, where we use a mixed buffer (not the flat code), and have BE and LE hashes in the same expression. These 'would' work for flat code just fine. The < 1000 formats should be easy (if I can not figure it out, I can #define out the stuff in preloads). The others will take more insight, since they are loaded by the parser.
7f687f5 fee8c77 complete the fixes.