openwall / john

John the Ripper jumbo - advanced offline password cracker, which supports hundreds of hash and cipher types, and runs on many operating systems, CPUs, GPUs, and even some FPGAs
https://www.openwall.com/john/
Other
10.24k stars 2.09k forks source link

Some formats fail the test on AVX512 #2273

Closed lei-april closed 6 years ago

lei-april commented 8 years ago

When tested on an Intel KNC processor, which supports AVX512, the following formats failed:

The only hint I found is they are all SHA formats.

magnumripper commented 6 years ago

As of cad492f09f the list was the exact same except 7z now worked.

The only hint I found is they are all SHA formats.

Yes but all different types of SHA. Here's the real hint:

$ git grep -l FLAT_OUT *fmt*c
SybaseASE_fmt_plug.c
blackberry_ES10_fmt_plug.c
drupal7_fmt_plug.c
ecryptfs_fmt_plug.c
office_fmt_plug.c
pwsafe_fmt_plug.c

Something's amiss with our pseudo-intrinsics for FLAT_OUT scatter. A work-around (revert to generic code) is now committed in dc61d377e, all formats now pass self-tests.

We might want to revisit the scatter-using-intrinsics later but I'm closing this.