openwall / john

John the Ripper jumbo - advanced offline password cracker, which supports hundreds of hash and cipher types, and runs on many operating systems, CPUs, GPUs, and even some FPGAs
https://www.openwall.com/john/
Other
10.05k stars 2.08k forks source link

Many formats lack tunable cost reporting #3910

Open magnumripper opened 5 years ago

magnumripper commented 5 years ago

Blockchain formats (CPU and OpenCL) has no costs defined, but they should. Although trivial, I couldn't care less if this is fixed for 1.9.0-Jumbo-1 or not so I'm not adding any milestone.

solardiz commented 5 years ago

I've added some FIXME comments about issues like this recently (to the format struct initializers), and you've added some more yesterday (to #define BENCHMARK_LENGTH lines). I think there's no reason to single out "Blockchain formats" for a GitHub issue. @frank-dittrich will hopefully look into all of those issues and add the missing code once he's back.