search

openwall / john

John the Ripper jumbo - advanced offline password cracker, which supports hundreds of hash and cipher types, and runs on many operating systems, CPUs, GPUs, and even some FPGAs
https://www.openwall.com/john/
Other
10.1k stars 2.08k forks source link

make's target ../run/dynacomptest is broken; also add it to CI? #5536

Open AlekseyCherepanov opened 2 weeks ago

AlekseyCherepanov commented 2 weeks ago

../run/dynacomptest is not built by default and it seems outdated.

$ make ../run/dynacomptest
[...]
dynamic_compiler.c: In function ‘dynamic_assign_script_to_format’:
dynamic_compiler.c:2639:45: error: ‘options’ undeclared (first use in this function); did you mean ‘optind’?

(I found the target because it was the only user of UNICODE_NO_OPTIONS that I needed for tests in #5531. There I'll fix a problem with options used in unicode.h.)

BTW it could work on CI as other tests in make check, could not it?

AlekseyCherepanov commented 2 weeks ago

Error in my previous message is from modified Makefile.in. Normal build fails earlier:

make: *** No rule to make target 'base64.o', needed by '../run/dynacomptest'.  Stop.
solardiz commented 1 week ago

I wasn't even aware of this make target.

@AlekseyCherepanov Is this something you want to fix? If so, please give it a try. Thanks!