search

openwall / john

John the Ripper jumbo - advanced offline password cracker, which supports hundreds of hash and cipher types, and runs on many operating systems, CPUs, GPUs, and even some FPGAs
https://www.openwall.com/john/
Other
10.25k stars 2.1k forks source link

Add Argon2 support to Keepass formats #5552

Open magnumripper opened 3 hours ago

magnumripper commented 3 hours ago

I've had a branch with Keepass formats supporting Argon2d and Argon2id since almost a year ago. Right before I made a PR, Alain introduced his argon2-opencl format, clashing with my branch. I need to pick up from where I stalled.

The stuff I had worked fine but was awfully slow on GPU (barely usable) so hopefully I can use some of Alain's GPU code for Keepass too. I need to grok it though, and it doesn't look particularly trivial.

At the very least I should rename clashing files and simply let the argon2 code versions live side by side.

solardiz commented 3 hours ago

I've had a branch with Keepass formats supporting Argon2d and Argon2id since almost a year ago.

It sounds like you had this for both CPU and OpenCL? If you also had it for CPU, it implies you had updated us to newer Argon2 upstream code to have 2id support, right? If so, you could submit that first as a separate PR, as we have an open issue for that and it's needed on its own, regardless of Keepass.