Closed bill-e-ghote closed 9 years ago
Thanks for reporting this. Hopefully @jfoug will have a look at it.
For now, I have sort of given up on rexgen. I can not build it any more as the recent changes (which do nothing for the lib) require a higher cmake version than I have.
More details in #693 which was closed as dupe.
@jfoug I can build latest rexgen with cmake 2.8.12.2, I thought you were using the same version?
Unfortunately teeshop/rexgen@c88601f is still the latest version we can use, and nothing has happened in that repo since June 18.
835ab0f updates JtR to work with latest code from https://github.com/teeshop/rexgen. Older versions are no longer supported (and ./configure will not enable regex mode if you have an old one).
BTW rexgen currently has to be cloned like this
git clone --recursive https://github.com/teeshop/rexgen.git
...and it requires icu4c lib and headers.
I still cannot build.
Reason:
The rexgen header files used to be installed to /usr/local/include/librexgen/api/c/
, but now are installed to /usr/local/include/<librexgen/c
, but john's regex.h still has
#include <librexgen/api/c/librexgen.h>
instead of
#include <librexgen/c/librexgen.h>
The configure script correctly checks for librexgen/c/librexgen.h
.
I wonder how it forked for you without the regex.h change.
May be discuss with Jan whether he intends to keep this API stable or whether we should expect future changes.
That include path may something he missed while patching (I guess we should commit it), and maybe he had an older file in the old loc. I have yet to succeed in building rexgen library on OSX due to other problems. We'll sort it out sooner or later.
May be discuss with Jan whether he intends to keep this API stable or whether we should expect future changes.
He does plan another change, for performance reasons (and he'll also get rid of the current dependency of icu4c). He will provide patches. But re-reading what he wrote I think he actually wont break the API this time, we just need the update to get the better performance available.
Rexgen page on code.google.com states: This project is currently moving to https://github.com/teeshop/rexgen
Installed rexgen from git source tree. JtR bleeding-jumbo from git source tree:
Comparison of rexgen code from git vs. previous code pulled from Google svn tree reveal - no reference to c_simplestring_bufferaddress in new code base.