search

openwallet-foundation-labs / identity-credential

Apache License 2.0
149 stars 76 forks source link

MDL Presentation Prompts - Consent, Biomentric, and Passphrase #633

Closed dritan-x closed 3 weeks ago

dritan-x commented 3 weeks ago

Consent Prompt can be shown via extension function FragmentActivity.showConsentPrompt() and returns a boolean. I did some minor cleanup refactoring to the Consent Prompt composable, such as renaming Share button val definition to Confirm. Located in package wallet.ui.prompt.consent.

Biometric Prompt can be shown via extension function FragmentActivity.showBiometricPrompt() and returns a boolean indicating whether biometric authentication was successful. Located in package wallet.ui.prompt.biometric.

Passphrase Prompt can be shown via extension function FragmentActivity.showPassphrasePrompt() and returns the passphrase string that was entered.

Test: all unit tests pass Test: manually launched Wallet app and performing an MDL Presentation between Wallet and AppVerifier

Original PR https://github.com/openwallet-foundation-labs/identity-credential/pull/631 (for the initial conversation)

davidz25 commented 3 weeks ago

Thanks for doing this. In the future please squash commits into a single commit and force push. You forgot this time and it litters the git history. Edit: disregard, looks like you squashed at the GitHub interface so the history is fine - I was looking at Android Studio git view which by default shows all local branches.