openwallet-foundation-labs / identity-credential

Apache License 2.0
149 stars 76 forks source link

Argument names in the HPKE decryption function do not match the intended use. #639

Open kokukuma opened 2 weeks ago

kokukuma commented 2 weeks ago

The fourth argument of this hpkeDecrypt function, written as additional authenticated data (aad), is used as the second argument of decryptor.decrypt, contextInfo. The name of the hpkeDecrypt argument may be incorrect.

https://github.com/openwallet-foundation-labs/identity-credential/blob/main/identity/src/main/java/com/android/identity/crypto/Crypto.kt#L779