search

openwallet-foundation-labs / identity-credential

Apache License 2.0
156 stars 80 forks source link

ErrorCode with value 0 missing in the device retrieval mdoc response for the missing data element #98

Closed vaimut closed 1 year ago

vaimut commented 2 years ago

Expected Behavior

As per ISO 18013-5(8.3.3.1.1.3) Standard Device retrieval mdoc response should contain an error code 0 for the missed item that are requested from the verifier.

Actual Behavior

A response without any error code for the missed items(requested items that are not present in Holder) is returned

This has been added in the TODO bucket list

Steps to Reproduce the Problem

  1. Perform device engagement using QR code or NFC and set up BLE for device retrieval
  2. De-select/remove some of the requested data items and share it

Specifications

Screenshot 2022-08-01 at 6 12 31 PM
davidz25 commented 2 years ago

Actually there is no such requirement, it's completely optional and this is on purpose. The standard says (emphasis mine): If the device retrieval mdoc response structure does not include some data element or document requested in the device retrieval mdoc request, an error code may be returned as part of the documentErrors or errors structures.

The reason the standard is written this way is for privacy reasons: the mDL may not want to confirm whether it has or has not a given data element. I clearly remember when this was discussed in I think the Portugal WG10 meeting in July 2019.

davidz25 commented 1 year ago

Reopening since this is an application-level policy decision on whether to return this.