Closed lukasjhan closed 6 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 97.73%. Comparing base (
612bf82
) to head (19445b7
).
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Hmm.. It's strange. biome success in local env
Hmm.. It's strange. biome success in local env
Same for me. Running biome ci . or pnpm run format or lint locally is fine.... There is also no update for the biome action in the cicd that could cause that
@lukasjhan found the error:
Biome release a new minor update, that added more rules. Locally, we are using version 1.5.0
, but when we used the github action, it is always going for latest, in our case 1.6.0
. So there were some new rules that causes the issue. I applied the changes, tests are passing.
Changes were applied via biome directly and not manually. Since all tests passed it should be fine
I referenced the biome call to the package json to make sure we got the same versions and therefore the same behavior local and in the ci.
@cre8 Thank you :)
I made _digest value in disclosure as public.
When implementing features in holder side, usually we decode the disclosures and make a logic. In this situation we normally have _digest value, not need to calculate. So delivering hasher to get _digest value is not necessary.
It closes #150