openwallet-foundation-labs / sd-jwt-js

A JavaScript implementation of the Selective Disclosure JWT (SD-JWT) spec.

https://sdjwt.js.org/

Apache License 2.0

36 stars 11 forks source link

Fix test CI for nodejs 16 #207

Closed lukasjhan closed 4 months ago

lukasjhan commented 4 months ago

Looks like new pnpm has version limit.

check here: https://github.com/openwallet-foundation-labs/sd-jwt-js/actions/runs/8707141840/job/23959522487#step:5:72

Maybe we need to use older pnpm to run the old version node tests

lukasjhan commented 4 months ago

204 #205 failed due to this issue. and PRs coming up in the future will also fail.

lukasjhan commented 4 months ago

https://github.com/pnpm/pnpm/releases/tag/v9.0.0

lukasjhan commented 4 months ago

Hi @cre8, Please check if the direction I corrected is okay. It also related with #206

cre8 commented 4 months ago

@lukasjhan based on the end of life information, I would suggest to drop support for version 16 instead of limiting the pnpm version not to be the latest version, see: https://endoflife.date/nodejs