openwallet-foundation-labs / sd-jwt-python

A Python implementation of the Selective Disclosure JWT (SD-JWT) spec.
Apache License 2.0
13 stars 13 forks source link

Adapt JSON serialization #19

Closed danielfett closed 4 months ago

danielfett commented 7 months ago

This implements JSON serialization as outlined in https://github.com/oauth-wg/oauth-selective-disclosure-jwt/issues/403 and defined in https://github.com/oauth-wg/oauth-selective-disclosure-jwt/pull/414

Noteworthy changes:

bc-pi commented 7 months ago
  • issuer_keys argument to the SDJWTIssuer MAY be an array of keys (but a single key is still supported, so no changes in legacy usages required)

but an update to the name in the settings.yml of dependent projects (like SD-JWT VC) will be needed, no?

c2bo commented 6 months ago
  • issuer_keys argument to the SDJWTIssuer MAY be an array of keys (but a single key is still supported, so no changes in legacy usages required)

but an update to the name in the settings.yml of dependent projects (like SD-JWT VC) will be needed, no?

What about catching the old yaml files during parsing, converting to the correct claim names (basically issuer_key -> issuer_keys for both functions parsing yaml files) and outputting a warning that issuer_key is deprecated? That would be a very small change and not break stuff.