search

openwallet-foundation-labs / wallet-framework-dotnet

Apache License 2.0
19 stars 5 forks source link

introduce batch issuance #213

Closed kenkosmowski closed 1 week ago

kenkosmowski commented 2 weeks ago

Short description of what this resolves:

This PR adds support for batch issuance.

Changes proposed in this pull request:

-

-

Fixes: #

JoTiTu commented 2 weeks ago

why did you choose to introduce a new type ProofsOfPocession and not some array with ProofOfPocession type?

kenkosmowski commented 2 weeks ago

why did you choose to introduce a new type ProofsOfPocession and not some array with ProofOfPocession type?

There is a little difference between "proof" and "proofs" in the crdential request object: https://openid.net/specs/openid-4-verifiable-credential-issuance-1_0.html#name-credential-request

So i thought it would be a good idea to introduce this new type that also has its own JSON encoding.