openwallet-foundation / acapy-endorser-service

endorser-service
https://wiki.hyperledger.org/display/aries
Apache License 2.0
6 stars 11 forks source link

Clearly define the use of the fields for Granular Configuration of Auto Endorsement #146

Closed WadeBarnes closed 2 months ago

WadeBarnes commented 2 months ago

The Granular Configuration of Auto Endorsement documentation does not provide a clear definition of how the various fields in the rules are used, which can lead to confusion.

Please update the documentation with clear definitions as to what values should be used in the fields.

For example, in the context of the credential_definition rules, the purpose for issuer_did and author_did are not described, so it is unclear which DIDs should be used to define the rule. As it turns out the issuer_did needs to be the DID that authored the Schema on which the Cred-Def will be defined (which in itself is a little confusing), and the author_did is the DID that will be authoring the cred-def. Side note: I'm almost wondering if the use of those fields should actually be reversed or renamed.

Reference;