search

openwallet-foundation / acapy-endorser-service

endorser-service
https://wiki.hyperledger.org/display/aries
Apache License 2.0
6 stars 11 forks source link

Correct duplicate primary key error #80

Closed Gavinok closed 6 months ago

Gavinok commented 6 months ago

Resolves #44 by catching db integrity errors and changing them into a HTTP 409 (conflict) error rather than a HTTP 500

Gavinok commented 6 months ago

Some small dependency changes where necessary in order to get both tests and the endorser running.

Gavinok commented 6 months ago

merged and tested changes from #78 and #79

loneil commented 6 months ago

Were there changes needed to get this working/building (regardless of specific changes for the feature here)?

I see a number of large dependency bumps recently https://github.com/hyperledger/aries-endorser-service/pulls?q=is%3Apr+is%3Aclosed so wondering if main was in a state where it was working prior to this?

loneil commented 6 months ago

If we can regression test after Gavin's fixes here and know that things are working on this codebase then yeah the previous changes are working. (probably, not sure how much regression needed for this repo)

Gavinok commented 6 months ago

@loneil I have ran the E2E regression tests and these changes seem to be working without issue. Not sure if that is what you had in mind

loneil commented 6 months ago

@loneil I have ran the E2E regression tests and these changes seem to be working without issue. Not sure if that is what you had in mind

If the BDD end-to-end is good enough coverage to rely on then yeah. I don't know enough about the coverage of those tests but it might be enough?

esune commented 6 months ago

@loneil I have ran the E2E regression tests and these changes seem to be working without issue. Not sure if that is what you had in mind

If the BDD end-to-end is good enough coverage to rely on then yeah. I don't know enough about the coverage of those tests but it might be enough?

I think they should be good enough for now, as the project evolves we may add-on to them, but currently the functionality is relatively simple.