Wallet Database not Removed after Removing Wallet

openwallet-foundation / acapy

Hyperledger Aries Cloud Agent Python (ACA-Py) is a foundation for building decentralized identity applications and services running in non-mobile environments.

https://wiki.hyperledger.org/display/aries

Apache License 2.0

412 stars 512 forks source link

Wallet Database not Removed after Removing Wallet #2039

Open PaulWen opened 1 year ago

PaulWen commented 1 year ago

Current Behaviour

When calling POST /multitenancy/wallet/XXXXX/remove the wallet is being removed but the corresponding database still remains in the Postgres DB. When calling GET /multitenancy/wallets the wallet is not listed anymore.

Expected Behaviour

The wallet DB should be removed from Postgres when removing the wallet via the AcaPy HTTP API.

Setup

AcaPy started in Multitenancy Mode
Askar Wallet
- the default database-per-wallet scheme is used
- Postgres is used

PaulWen commented 1 year ago

I also raised this topic in Discord (https://discord.com/channels/905194001349627914/1047175776228888698) and received the following hint from @andrewwhitehead:

It looks like the logic here might need to be updated to remove the database (Store) when multitenant_wallet_name is set https://github.com/hyperledger/aries-cloudagent-python/blob/e19cd6fe9f68407ddf640d7c90257270dfb63d40/aries_cloudagent/multitenant/askar_profile_manager.py#L87

mohdhasnain123 commented 3 months ago

I have also tried this api and its not working as expected. Please change the code logic to delete wallet db from postgres also.