openwallet-foundation / acapy

ACA-Py is a foundation for building decentralized identity applications and services running in non-mobile environments.
https://aca-py.org
Apache License 2.0
420 stars 513 forks source link

Handling “version” and upgrades when “version” not found in storage #2197

Closed swcurran closed 1 year ago

swcurran commented 1 year ago

When an existing agent upgrades to a version of ACA-Py that is aware of the versions and auto-upgrades, there is the possibility that “version” is not found in secure storage. The current behaviour is to continue with an note in the log. If that note is missed, the agent will fovever continue without necessary upgrades.

I propose that the behaviour be changed to the following:

When the from version is not found in storage for an existing agent, it should be set to the value0.7.5, which should trigger an upgrade from that version to the current version. In the normal flow of the upgrade, the current version will be put in storage.

Why is hardcoding 0.7.5 safe?

swcurran commented 1 year ago

FYI @shaangill025 and @WadeBarnes. I’d like to get this into the release before 0.8.1. Do you agree?