When an existing agent upgrades to a version of ACA-Py that is aware of the versions and auto-upgrades, there is the possibility that “version” is not found in secure storage. The current behaviour is to continue with an note in the log. If that note is missed, the agent will fovever continue without necessary upgrades.
I propose that the behaviour be changed to the following:
When the from version is not found in storage for an existing agent, it should be set to the value0.7.5, which should trigger an upgrade from that version to the current version. In the normal flow of the upgrade, the current version will be put in storage.
Why is hardcoding 0.7.5 safe?
This will happen from 0.8.1 forward (or when we add this feature).
The upgrades from all versions prior to 0.7.5 are the same — resave the connection records, so any old version to 0.8.1 are safe. Further, if the agent is a 0.8.0 upgrading to a 0.8.1, the upgrade may be unnecessary, but it will not damage the instance.
An upgrade of such an instance to a future version that requires an offline upgrade will still be handled safely.
When an existing agent upgrades to a version of ACA-Py that is aware of the versions and auto-upgrades, there is the possibility that “version” is not found in secure storage. The current behaviour is to continue with an note in the log. If that note is missed, the agent will fovever continue without necessary upgrades.
I propose that the behaviour be changed to the following:
When the
from
version is not found in storage for an existing agent, it should be set to the value0.7.5
, which should trigger an upgrade from that version to the current version. In the normal flow of the upgrade, the current version will be put in storage.Why is hardcoding
0.7.5
safe?0.8.1
forward (or when we add this feature).0.7.5
are the same — resave the connection records, so any old version to0.8.1
are safe. Further, if the agent is a0.8.0
upgrading to a0.8.1
, the upgrade may be unnecessary, but it will not damage the instance.offline
upgrade will still be handled safely.