openwallet-foundation / acapy

Hyperledger Aries Cloud Agent Python (ACA-Py) is a foundation for building decentralized identity applications and services running in non-mobile environments.
https://wiki.hyperledger.org/display/aries
Apache License 2.0
412 stars 512 forks source link

Drop support for Python 3.6 #2244

Closed swcurran closed 1 year ago

swcurran commented 1 year ago

It’s now time to drop support for Python 3.6. What needs to be done to make that happen? I’m guessing the list is something like:

FYI BC Gov has updated all deployments from Python 3.6 to 3.9 and there were no issues identified.

Adjustments/additions @WadeBarnes @dbluhm ?

WadeBarnes commented 1 year ago

I think we should go straight to using a minimum of Python 3.9. All of the tests are passing for that version and we're already building and publishing images for py3.9 here https://github.com/hyperledger/aries-cloudagent-python/pkgs/container/aries-cloudagent-python. BC Gov, as @swcurran pointed out, is using these images to upgrade all services and we've had great success using the py3.9 images as drop-in replacement/upgrade for all previous versions. Moving to py3.9 as the minimum means we just need to drop the support for py3.6 and py3.7 in a few GitHub workflows from a CI/CD perspective.

So:

@swcurran, as a separate topic we need to discuss what to do with bcgovimages/aries-cloudagent due to it's 50M+ download profile.

swcurran commented 1 year ago

I think we need to transition the bcgovimages/aries-cloudagent as well, but open to suggestions on the best way. I guess since the image is a replacement, we should be able to just move the latest tag to a Python 3.9 one?

WadeBarnes commented 1 year ago

Could be as simple as relabeling/retagging the image and pushing it to the exiting repo, and updating the documentation to indicate it's acting as a mirror of sorts.