search

openwallet-foundation / acapy

ACA-Py is a foundation for building decentralized identity applications and services running in non-mobile environments.
https://aca-py.org
Apache License 2.0
421 stars 515 forks source link

Messages with an empty ~thread decorator #2259

Closed usingtechnology closed 1 year ago

usingtechnology commented 1 year ago

0.8.1 is sending messages with an empty ~thread.

This can confuse callers as RFC 0008 appears ambiguous; it states what to do if ~thread has not thid and what to do if no ~thread, but not what to do with ~thread with no thid.

If ACA-Py has no data in the ~thread, then let's not include it.

See https://github.com/hyperledger/aries-vcx/issues/875

usingtechnology commented 1 year ago

After looking through ACA-Py code, it is pretty clear that thid is not always expected to be populated in a ~thread, so I think we need to do this on a case-by-case basis.

However, the code clearly shows that thid was intended to be populated for credential-offer and there is a bug here. I will file a PR to address that bug.