search

openwallet-foundation / acapy

ACA-Py is a foundation for building decentralized identity applications and services running in non-mobile environments.
https://aca-py.org
Apache License 2.0
412 stars 512 forks source link

ACA-Py Version has changed format from the last RC #2579

Closed nodlesh closed 11 months ago

nodlesh commented 11 months ago

I believe we've changed the format of the acapy version in the latest rc. I'm building agents from ACA-Py main every night in Aries Agent Test Harness and the version from ./bin/aca-py --version is combing back as 0.11.0rc1 instead of the historical and expected 0.11.0-rc1. There is some processing of the version in the AATH acapy backchannel that is used for version comparison that is failing because of this. This issue started in the BC Wallet Test Pipeline on the evening of Oct 30.

It is also likely that the admin_url/status api returns the illformed version format.

swcurran commented 11 months ago

@esune — getting someone looking at this sooner than later would be a good thing.

esune commented 11 months ago

It is looking like we are going to keep the current behaviour, as it follows the official PEP 440 rules.

@nodlesh I think the best course of action would be to update the handling in AATH to recognize the updated versioning scheme.

swcurran commented 11 months ago

There is an AATH issue created to deal with this, and @nodlesh is updating AATH accordingly.

From now on, in the tags, releases, etc. we’ll leave off the “-“ entirely.