search

openwallet-foundation / acapy

Hyperledger Aries Cloud Agent Python (ACA-Py) is a foundation for building decentralized identity applications and services running in non-mobile environments.
https://wiki.hyperledger.org/display/aries
Apache License 2.0
408 stars 512 forks source link

introduce ACAPY_NO_BANNER--no-banner and replace print statements by logging in plugins #3203

Closed rngadam closed 3 weeks ago

rngadam commented 1 month ago

see issue #3202

rngadam commented 1 month ago

See my comments here; #3202 (comment). I don't think suppressing deprecation notices is a good idea, it defeats their purpose.

Regarding the standard ACA-Py startup banner. I think this is a very important piece of diagnostic information that should not be suppressed. It provides you with a summary of the agent configuration and version that can help you identify issues right off the bat.

Outputting the banner is the default. ACAPY_NO_BANNER allows to suppress the banner output in situation where the information in diagnostic is already known to the user.

sonarcloud[bot] commented 1 month ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

swcurran commented 1 month ago

I've added this to the ACA-Pug meeting coming up this Tuesday, Sept. 3 at 8:00 Pacific / 17:00 Central Europe. @rngadam -- would you be able to make that? Details are here: https://wiki.hyperledger.org/display/ARIES/2024-09-03+Aries+Cloud+Agent+-+Python+Users+Group+Community+Meeting

jamshale commented 3 weeks ago

Closing this as won't do. Feel free to re-open it if this is still something you really think is needed.