Open dbluhm opened 1 month ago
I stewed on how best to handle the OOB invitation attachments for these v1 protocols when they're no longer in the core repo. I think the way I would approach this is:
InvitationCreator
from OOB package and override the create_attachment
or add a method that handles creating an OOB attachment for a v1 cred issuance or proof presentation.InvitationCreator
should encapsulate enough of the hard stuff that having multiple endpoints for OOB invite generation shouldn't be too bad.Failed conditions
3.0% Duplication on New Code (required ≤ 3%)
C Maintainability Rating on New Code (required ≥ A)
See analysis details on SonarCloud
Catch issues before they fail your Quality Gate with our IDE extension SonarLint
This PR removes Issue Credential v1 and Present Proof v1.
This is a rough cut of these changes that will need to be further refined.
Notes on sharp edges to be added.
Change Notes
Issue Credential v1
To enable ICv1 to continue to exist as a plugin, the following changes are/were necessary:
Present Proof v1
To enable PPv1 to continue to exist as a plugin, the following changes are/were necessary: