search

openwallet-foundation / acapy

ACA-Py is a foundation for building decentralized identity applications and services running in non-mobile environments.
https://aca-py.org
Apache License 2.0
419 stars 512 forks source link

`--base-wallet-routes` flag no longer works #3283

Open dbluhm opened 1 month ago

dbluhm commented 1 month ago

After the swap to using decorators to delineate routes accessible by tenants and routes accessible by admins, the ability to grant access to the base wallet to additional routes was lost.

This option made it possible for a base wallet to form a didcomm connection with a mediator and then use that as a base mediator for all tenants, among other things.

cc @esune @jamshale

jamshale commented 1 month ago

So many configs... Guess the flag wasn't tested. I'll wait and see if Emiliano knows an easy way to fix it.

dbluhm commented 1 month ago

Yeah, indeed, I only just detected this myself.

esune commented 1 month ago

I didn't even know this setting/option existed 😅. My understanding was that the base wallet would always ONLY deal with tenant provisioning tasks and nothing else, so the decorators were set-up to function this way.

That being said, I think we would have to move this logic into the tenant_authentication decorator for things to work.

Adding a separate decorator just for this would be also an option and it would be more explicit, however the fact that we'd have to basically blanket apply it everywhere AND, more importantly, the added complexity of having multiple decorators stacked (in the right order) makes me think it is actually not the best option.

esune commented 2 days ago

Taking a stab at this since it was brought up at today's maintainers meeting