Remove in memory wallet

openwallet-foundation / acapy

ACA-Py is a foundation for building decentralized identity applications and services running in non-mobile environments.

https://aca-py.org

Apache License 2.0

419 stars 512 forks source link

Remove in memory wallet #3311

Closed jamshale closed 2 weeks ago

jamshale commented 4 weeks ago

Removes the in-memory wallet and updates tests to use an in-memory sqlite askar wallet.
Doesn't flatten the wallet abstraction in this PR. Will do this in an additional PR.
Runs the tests in parallel to speed up execution time.
Updates all tests that created an in-memory (non-async) profile (wallet) to use the async askar wallet.
test_dispatcher had a few tests that are skipped. It seems like there might be bug in this code preventing them from working.
there was one problematic test in test_conductor that I skipped. It has a bad mock somewhere and was causing other tests to fail when run sequentially.

sonarcloud[bot] commented 2 weeks ago

Quality Gate failed

Failed conditions
4 Security Hotspots

See analysis details on SonarCloud

jamshale commented 2 weeks ago

Switching to a raw key dramatically sped up the tests. Whole PR Tests take less than 3 minutes now.

jamshale commented 2 weeks ago

This should be ready. It is a breaking change for external plugins that use the old in_memory_profile for testing.

swcurran commented 2 weeks ago

Wow that is a big change. I hope you had some editor automation to help with that! LGTM, but will defer to @dbluhm @ff137 (or other maintainers) for an approval.

dbluhm commented 2 weeks ago

@jamshale if a wallet type is not specified on startup, do we spin up with an in-memory askar wallet? (if so, this should also probably be using raw key method and Store.generate_key)

dbluhm commented 2 weeks ago

This is great! I'm interested in taking this one step further after this PR is merged and flattening some of the wallet related abstractions now that there is just Askar.