openwallet-foundation / acapy

ACA-Py is a foundation for building decentralized identity applications and services running in non-mobile environments.
https://aca-py.org
Apache License 2.0
419 stars 512 forks source link

Don't pass rekey to sub_wallet_profile #3312

Closed jamshale closed 1 week ago

jamshale commented 4 weeks ago

This should be all that is needed to allow multitenancy single wallet mode to work with the rekey feature. In single wallet mode the multitenant_sub_wallet is always created without a key. I guess this is ok because the subwallets should have a key.

When the rekey feature was applied it would send the new key to try to open the multitenant_sub_wallet, resulting in a failure to open the wallet.

There is other work to be done here. Right now in single wallet mode it is possible to make subwallets without a key and there is no rekey feature for subwallets. See https://github.com/openwallet-foundation/acapy/issues/3307

sonarcloud[bot] commented 1 week ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud