search

openwallet-foundation / acapy

ACA-Py is a foundation for building decentralized identity applications and services running in non-mobile environments.
https://aca-py.org
Apache License 2.0
420 stars 513 forks source link

:art: Refactor string concatenation in model descriptions #3313

Closed ff137 closed 1 month ago

ff137 commented 1 month ago

Just some minor artsy cleanup --

I noticed that using the backslash for line continuation includes all the whitespace of the code indentation in the final string. So, the openapi docs would generate a description as:

The value is used once for a particular domain and window of time.                     This value is ...

So, quick fix: replace \ for line continuation with string concatenation

edit: also fixes mediation typo, while I'm at it

jamshale commented 1 month ago

Not sure why this got caught in the unit tests but not ruff linting check, but looks like one line is too long.

image

ff137 commented 1 month ago

@jamshale Thanks! Forgot to check

sonarcloud[bot] commented 1 month ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud