Closed ff137 closed 2 weeks ago
5.0% Duplication on New Code (required ≤ 3%)
Can we increase this threshold to something more pragmatic? 10-20% would make sense
5.0% Duplication on New Code (required ≤ 3%)
Can we increase this threshold to something more pragmatic? 10-20% would make sense
We can, but it's a bit of an annoying process because none of the maintainers have admin rights on the sonarcloud project right now. There is ways to set setting in the sonar-project.properties file and the github action but I haven't experimented much with this. For now I think we'll just have to comment when you think something should be ignored, but I would like to clean some of these reports up in the future.
Issues
0 New issues
0 Accepted issues
Measures
0 Security Hotspots
91.7% Coverage on New Code
0.7% Duplication on New Code
Closes #3322
Currently, NotFound and UnprocessableEntity errors would print stack traces in the logs. It is more sensible to record these as info logs, since they typically represent bad requests / client errors.
This PR contributes changes so that the new behaviour will print messages like:
A util method
extract_validation_error_message
was added to help print this marshmallow validation error, so that the logs still provide the error context previously contained in the stack trace.:art: Other minor amendments included as well:
"Note: setting ledger to read-only mode"
). I opted to set these to warning levelready_middleware
to reduce complexity