search

openwallet-foundation / architecture-sig

This special interest group (SIG) is focused on conversations related to the architecture of digital wallet engines and is a sub-group reporting to the OpenWallet Foundation's Technical Advisory Committee.
Creative Commons Attribution 4.0 International
42 stars 16 forks source link

Update README.md #42

Open TomCJones opened 1 year ago

TomCJones commented 1 year ago

added use case

OR13 commented 1 year ago

@tkuhrt anything I need to do for the DCO ?

tkuhrt commented 1 year ago

Looks like someone enabled DCO checks on the repo. All commits will need to be done with git commit -s. This page from Hyperledger Indy provides some info on signing commits and previous commits.

OR13 commented 1 year ago

Is there an option to NOT require this repo be doing what it is now?

I don't feel like this is an improvement.

Do I have permission to merge over the current error?

I don't feel like the contributor should be required to review anything related to Hyperledger Indy to contribute here.

tkuhrt commented 1 year ago

@OR13 : DCO is required by the charter. I assume someone at the Linux Foundation enabled this check, as I did not. There are many places that explain how to fix DCO, the one I linked to in Indy is just one of them. Here is the top result from Google for "fix DCO sign off for PR"

OR13 commented 1 year ago

@tkuhrt I am taking your response as a blocker for merging and I am requesting changes.