search

openwallet-foundation / askar

Secure storage designed for Hyperledger Aries agents.
Apache License 2.0
63 stars 51 forks source link

fix(js): storeRekey in React Native #161

Closed genaris closed 1 year ago

genaris commented 1 year ago

StoreRekey for React Native was not calling the proper method.

genaris commented 1 year ago

@thiagoromanos

TimoGlastra commented 1 year ago

- Do we also want to make a new release right away

thiagoromanos commented 1 year ago

Do we also want to make a new release right away

If it's possible, it would be great, @TimoGlastra. Key rotation is a essential functionality for a feature my team is developing.

genaris commented 1 year ago

Do we also want to make a new release right away

I guess so, as different teams encountered issues related to this recently. It would not require new release at AFJ side, right? I mean consumers of the framework can use @hyperledger/aries-askar-react-native 0.1.1 if they want? (currently @aries-framework/askar has @hyperledger/aries-askar-shared: "^0.1.0" as peerDependency)

andrewwhitehead commented 1 year ago

It would be nice to merge #159 before a release. I also had a minor update to the Python wrapper planned, and the next version should be 0.4 due to a bunch of dependency updates and some breaking changes to the Rust API.

swcurran commented 1 year ago

Added some reviewers on #159 so we can get that merged along with this one for a release.

genaris commented 1 year ago

No problem, but this is a quick fix specific to JS wrapper. I thought @TimoGlastra was referring to releasing a new version of the wrappers only (i.e. release a 0.1.1 version for shared/nodejs/react-native). Isn't it possible with current CI/CD?

thiagoromanos commented 1 year ago

No problem, but this is a quick fix specific to JS wrapper. I thought @TimoGlastra was referring to releasing a new version of the wrappers only (i.e. release a 0.1.1 version for shared/nodejs/react-native). Isn't it possible with current CI/CD?

Is it possible to publish a non-final release, like an alpha or something like that, just to be able to use that package already?

andrewwhitehead commented 1 year ago

We probably should do one or two 0.4 dev releases. The update from sqlx 0.6 to 0.7 is a fairly big one, although I'm not seeing any issues so far. This fix should be good for sqlite stability as well, I think it resolved the intermittent test failures on CI: https://github.com/launchbadge/sqlx/pull/2573

swcurran commented 1 year ago

@andrewwhitehead — who is “we” on this. I don’t want this falling between the cracks. Are you the one to do the dev releases, and is there anything preventing them from happening?

andrewwhitehead commented 1 year ago

I can or Berendt and Timo have created releases in the past. It just means updating the version numbers appropriately (can be slightly tricky as the format for dev versions varies between Rust/Python/JS) and creating a release on Github.

TimoGlastra commented 1 year ago

As there is changes to the native bundle that don't have updates yet to the JS wrapper, I'm going to create a patch release for the JS wrapper for now. This will keep the existing native code, as it's a JS package only change

Then we can update the JS wrapper to support the new features form the recent PRs and get that also released

TimoGlastra commented 1 year ago

Made a PR to update the version for JS: https://github.com/hyperledger/aries-askar/pull/165, so at least this PR can be released without any updates to the native bundle

TimoGlastra commented 1 year ago

v0.1.1 has now been released. I think it should automatically install the new version if you remove your yarn.lock and regenerate it, but you can also force it by adding the v0.1.1 dependency for both /sahred and /react-native to your project