openwallet-foundation / askar

Secure storage designed for Hyperledger Aries agents.
Apache License 2.0
63 stars 51 forks source link

Refactor storage into a separate crate #90

Closed andrewwhitehead closed 1 year ago

andrewwhitehead commented 1 year ago

Also improves the public API of 'Store' and tidies up the crate exports.

Includes updates to scan records without a category filter (preparation for profile export/migration support).

In draft due to breaking changes, awaiting another minor release.

Follow up from #89

andrewwhitehead commented 1 year ago

This is looking great! I see some minor things changed in the python wrapper, are there any breaking changes from an FFI perspective, i.e. the JavaScript wrapper must also be updated? If so, I am happy to pick that up.

Most of the changes there are added docstrings, but the category filter is now optional (can be null) for scan_start, count, fetch_all and remove_all.