openwallet-foundation / bifold-wallet

Aries Mobile Agent React Native - Part of the Aries Bifold effort to provide SSI capabilities in a production ready app.
Apache License 2.0
136 stars 134 forks source link

feat: added ability to group proofs by referent instead of cred name #1136

Closed wadeking98 closed 1 month ago

wadeking98 commented 2 months ago

Summary of Changes

A few months ago I added a patch to the way the wallet handles proof requests because sometimes proofs would ask for attributes and predicates in separate groups (referents). This resulted in the proof being split up across multiple credential cards and could be a bit of a confusing UI for users. The patch I added 6 months ago addressed this by grouping based of credential name so that any proof asking for data from the same credential would be grouped into the same card. @CarolineLCa and her team need the old functionality where credentials are grouped by referent rather than by cred name. This PR adds support for grouping by referent. To use this feature in your project, override the container-impl.ts file and set this.container.registerInstance(TOKENS.GROUP_BY_REFERENT, false) to true

Related Issues

N/A

Pull Request Checklist

Tick all boxes below to demonstrate that you have completed the respective task. If the item does not apply to your this PR check it anyway to make it apparent that there's nothing to do.

If you have any questions to any of the points above, just submit and ask! This checklist is here to help you, not to deter you from contributing!

Pro Tip 🤓

PR template adapted from the Python attrs project.

sonarcloud[bot] commented 1 month ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.1% Duplication on New Code

See analysis details on SonarCloud