A few months ago I added a patch to the way the wallet handles proof requests because sometimes proofs would ask for attributes and predicates in separate groups (referents). This resulted in the proof being split up across multiple credential cards and could be a bit of a confusing UI for users. The patch I added 6 months ago addressed this by grouping based of credential name so that any proof asking for data from the same credential would be grouped into the same card. @CarolineLCa and her team need the old functionality where credentials are grouped by referent rather than by cred name. This PR adds support for grouping by referent. To use this feature in your project, override the container-impl.ts file and set this.container.registerInstance(TOKENS.GROUP_BY_REFERENT, false) to true
Related Issues
N/A
Pull Request Checklist
Tick all boxes below to demonstrate that you have completed the respective task. If the item does not apply to your this PR check it anyway to make it apparent that there's nothing to do.
[x] All commits contain a DCO Signed-off-by line (we use the DCO GitHub app to enforce this);
[x] Updated LICENSE-3RD-PARTY.md for any added dependencies or vendored components;
[x] Updated documentation as needed for changed code and new or modified features;
[x] Added sufficient tests so that overall code coverage is not reduced.
If you have any questions to any of the points above, just submit and ask! This checklist is here to help you, not to deter you from contributing!
Pro Tip 🤓
Read our contribution guide at least once; it will save you a few review cycles!
Your PR will likely not be reviewed until all the above boxes are checked and all automated tests have passed.
PR template adapted from the Python attrs project.
Summary of Changes
A few months ago I added a patch to the way the wallet handles proof requests because sometimes proofs would ask for attributes and predicates in separate groups (referents). This resulted in the proof being split up across multiple credential cards and could be a bit of a confusing UI for users. The patch I added 6 months ago addressed this by grouping based of credential name so that any proof asking for data from the same credential would be grouped into the same card. @CarolineLCa and her team need the old functionality where credentials are grouped by referent rather than by cred name. This PR adds support for grouping by referent. To use this feature in your project, override the
container-impl.ts
file and setthis.container.registerInstance(TOKENS.GROUP_BY_REFERENT, false)
to trueRelated Issues
N/A
Pull Request Checklist
Tick all boxes below to demonstrate that you have completed the respective task. If the item does not apply to your this PR check it anyway to make it apparent that there's nothing to do.
Signed-off-by
line (we use the DCO GitHub app to enforce this);If you have any questions to any of the points above, just submit and ask! This checklist is here to help you, not to deter you from contributing!
Pro Tip 🤓
PR template adapted from the Python attrs project.