Summary of Changes

Expected behavior

Correct names of credentials in the proof request.

Current behavior

The credential does not come with the correct name since parseCredDefFromId was not updated to deal with this new credDefId format.

To fix

I added parseIndyCredentialDefinitionId and parseIndySchemaId.

Observation

For the CredentialCard11 attribute, I added a non-null validation because when the attribute has a value of 0 it was not considered in the proof request

Related Issues

N/A

Pull Request Checklist

Tick all boxes below to demonstrate that you have completed the respective task. If the item does not apply to your this PR check it anyway to make it apparent that there's nothing to do.

[X] All commits contain a DCO Signed-off-by line (we use the DCO GitHub app to enforce this);
[X] Updated LICENSE-3RD-PARTY.md for any added dependencies or vendored components;
[X] Updated documentation as needed for changed code and new or modified features;
[ ] Added sufficient tests so that overall code coverage is not reduced.

If you have any questions to any of the points above, just submit and ask! This checklist is here to help you, not to deter you from contributing!

Pro Tip 🤓

Read our contribution guide at least once; it will save you a few review cycles!
Your PR will likely not be reviewed until all the above boxes are checked and all automated tests have passed.

PR template adapted from the Python attrs project.

openwallet-foundation / bifold-wallet

feat: improving parseCredDefFromId function and CredentialCard11 attribute value #1155