openwallet-foundation / bifold-wallet

Aries Mobile Agent React Native - Part of the Aries Bifold effort to provide SSI capabilities in a production ready app.
Apache License 2.0
136 stars 134 forks source link

fix: add logging and fix malformed deeplink handling #1163

Closed bryce-mcmath closed 3 weeks ago

bryce-mcmath commented 3 weeks ago

Summary of Changes

There was an unnecessary second attempt at fetching from a scanned / deeplinked URI as if it was a redirect URL. The built in Credo methods already attempt to do that here. This change removes that second attempt and adds more logging to help troubleshoot future issues. It also makes the sole difference in handling between scan and deeplink that deeplinks will fail silently (but still log) if there are no valid query params available in the URI whereas scanning will throw and show an invalid QR code error.

Related Issues

N/A

Pull Request Checklist

Tick all boxes below to demonstrate that you have completed the respective task. If the item does not apply to your this PR check it anyway to make it apparent that there's nothing to do.

If you have any questions to any of the points above, just submit and ask! This checklist is here to help you, not to deter you from contributing!

Pro Tip 🤓

PR template adapted from the Python attrs project.

sonarcloud[bot] commented 3 weeks ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.9% Duplication on New Code

See analysis details on SonarCloud