It should have the verifier's name in connectionless proof
Current behavior
"A contact" is displayed as name
To fix
I added useOutOfBandByReceivedInvitationId hooks to get oobLabel on ProofRequest screen
Before
After
Observation
For the cred_def, I added a else to prevent it from returning "default" when schemaId is undefined
Related Issues
N/A
Pull Request Checklist
Tick all boxes below to demonstrate that you have completed the respective task. If the item does not apply to your this PR check it anyway to make it apparent that there's nothing to do.
[X] All commits contain a DCO Signed-off-by line (we use the DCO GitHub app to enforce this);
[X] Updated LICENSE-3RD-PARTY.md for any added dependencies or vendored components;
[X] Updated documentation as needed for changed code and new or modified features;
[X] Added sufficient tests so that overall code coverage is not reduced.
If you have any questions to any of the points above, just submit and ask! This checklist is here to help you, not to deter you from contributing!
Pro Tip đŸ¤“
Read our contribution guide at least once; it will save you a few review cycles!
Your PR will likely not be reviewed until all the above boxes are checked and all automated tests have passed.
PR template adapted from the Python attrs project.
Summary of Changes
Expected behavior
It should have the verifier's name in connectionless proof
Current behavior
"A contact" is displayed as name
To fix
I added
useOutOfBandByReceivedInvitationIdhooks to getoobLabelon ProofRequest screenBefore
After
Observation
For the cred_def, I added a else to prevent it from returning "default" when
schemaIdis undefinedRelated Issues
N/A
Pull Request Checklist
Tick all boxes below to demonstrate that you have completed the respective task. If the item does not apply to your this PR check it anyway to make it apparent that there's nothing to do.
Signed-off-byline (we use the DCO GitHub app to enforce this);If you have any questions to any of the points above, just submit and ask! This checklist is here to help you, not to deter you from contributing!
Pro Tip đŸ¤“
PR template adapted from the Python attrs project.