openwallet-foundation / bifold-wallet

Aries Mobile Agent React Native - Part of the Aries Bifold effort to provide SSI capabilities in a production ready app.
Apache License 2.0
146 stars 140 forks source link

feat: refactored custom notification from custom config to use tsyringe container api #1211

Closed wadeking98 closed 2 months ago

wadeking98 commented 2 months ago

Summary of Changes

refactored the custom notification code to use our tsyringe setup rather than the dated custom config. This is part of a change taking place in BC Wallet to extend the person credential notification with more functionality

Related Issues

N/A

Pull Request Checklist

Tick all boxes below to demonstrate that you have completed the respective task. If the item does not apply to your this PR check it anyway to make it apparent that there's nothing to do.

If you have any questions to any of the points above, just submit and ask! This checklist is here to help you, not to deter you from contributing!

Pro Tip 🤓

PR template adapted from the Python attrs project.

sonarcloud[bot] commented 2 months ago

Quality Gate Passed Quality Gate passed

Issues
7 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

MosCD3 commented 2 months ago

Apply related fix #1213