FarjadGov14 commented 1 month ago

Summary of Changes

add inline error messages for PINEnter screen
modify the toggleButton colour use for when its enabled, a quick fix from last PR
add locale for english and french
fix the border colour for PINInput component

Related Issues

Previous PRs for bifold that are linked to it

Screen recording

https://github.com/user-attachments/assets/4d30711a-6d27-428b-9a42-350cd960e398

Pull Request Checklist

Tick all boxes below to demonstrate that you have completed the respective task. If the item does not apply to your this PR check it anyway to make it apparent that there's nothing to do.

[x] All commits contain a DCO Signed-off-by line (we use the DCO GitHub app to enforce this);
[x] Updated LICENSE-3RD-PARTY.md for any added dependencies or vendored components;
[x] Updated documentation as needed for changed code and new or modified features;
[x] Added sufficient tests so that overall code coverage is not reduced.

If you have any questions to any of the points above, just submit and ask! This checklist is here to help you, not to deter you from contributing!

Pro Tip 🤓

Read our contribution guide at least once; it will save you a few review cycles!
Your PR will likely not be reviewed until all the above boxes are checked and all automated tests have passed.

PR template adapted from the Python attrs project.

MosCD3 commented 1 month ago

This conflicts with #1253

sonarcloud[bot] commented 1 month ago

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

codecov-commenter commented 1 month ago

Codecov Report

Attention: Patch coverage is 15.38462% with 11 lines in your changes missing coverage. Please review.

Project coverage is 57.00%. Comparing base (f475eed) to head (5ca30a8). Report is 14 commits behind head on main.

Files with missing lines	Patch %	Lines
packages/legacy/core/App/screens/PINEnter.tsx	15.38%	11 Missing :warning:

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #1294 +/- ## ========================================== - Coverage 57.12% 57.00% -0.12% ========================================== Files 204 207 +3 Lines 6980 7075 +95 Branches 1978 2001 +23 ========================================== + Hits 3987 4033 +46 - Misses 2971 3020 +49 Partials 22 22 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

openwallet-foundation / bifold-wallet

feat: add inline error messages for pin enter screen #1294