openwallet-foundation / bifold-wallet

Aries Mobile Agent React Native - Part of the Aries Bifold effort to provide SSI capabilities in a production ready app.
Apache License 2.0
153 stars 149 forks source link

chore: improve biometrics permission prompting. #1301

Closed tom11-nguyen closed 2 weeks ago

tom11-nguyen commented 3 weeks ago

Summary of Changes

Related Issues

bcgov/bc-wallet-mobile#2111 openwallet-foundation/bifold-wallet#999

Pull Request Checklist

Tick all boxes below to demonstrate that you have completed the respective task. If the item does not apply to your this PR check it anyway to make it apparent that there's nothing to do.

If you have any questions to any of the points above, just submit and ask! This checklist is here to help you, not to deter you from contributing!

Pro Tip 🤓

PR template adapted from the Python attrs project.

tom11-nguyen commented 2 weeks ago

Have you also tested these changes when altering biometry setting from the settings menu (after user has logged in)? ie. the case where usage is UseBiometryUsage.ToggleOnOff?

Yes, I did test that screen, too

sonarcloud[bot] commented 2 weeks ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud