al-rosenthal commented 2 weeks ago

Summary of Changes

Updated proof request logic to specify attributes that are missing from a wallet and adds a 'missing' label
Credentials with missing attributes still show other available attributes
Updated snapshots to account for new UI
added 'hasError' to credential attribute
Fixed issues with OCA branding being overwritten on invalid proof requests
The below photos show updated UI with regards to a proof request with missing data (Person credential does not has a 'First name' field) and a proof request made against a revoked credential:

Media (3)

Media (2)

Related Issues

Pull Request Checklist

Tick all boxes below to demonstrate that you have completed the respective task. If the item does not apply to your this PR check it anyway to make it apparent that there's nothing to do.

[x] All commits contain a DCO Signed-off-by line (we use the DCO GitHub app to enforce this);
[x] Updated LICENSE-3RD-PARTY.md for any added dependencies or vendored components;
[x] Updated documentation as needed for changed code and new or modified features;
[x] Added sufficient tests so that overall code coverage is not reduced.

If you have any questions to any of the points above, just submit and ask! This checklist is here to help you, not to deter you from contributing!

Pro Tip 🤓

Read our contribution guide at least once; it will save you a few review cycles!
Your PR will likely not be reviewed until all the above boxes are checked and all automated tests have passed.

PR template adapted from the Python attrs project.

codecov-commenter commented 2 weeks ago

Codecov Report

Attention: Patch coverage is 85.71429% with 3 lines in your changes missing coverage. Please review.

Project coverage is 56.80%. Comparing base (f475eed) to head (0600f4f). Report is 28 commits behind head on main.

Files with missing lines	Patch %	Lines
...gacy/core/App/components/misc/CredentialCard11.tsx	71.42%	2 Missing :warning:
packages/legacy/core/App/utils/helpers.ts	92.30%	1 Missing :warning:

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #1307 +/- ## ========================================== - Coverage 57.12% 56.80% -0.32% ========================================== Files 204 213 +9 Lines 6980 7410 +430 Branches 1978 2096 +118 ========================================== + Hits 3987 4209 +222 - Misses 2971 3179 +208 Partials 22 22 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.