openwallet-foundation / bifold-wallet

Aries Mobile Agent React Native - Part of the Aries Bifold effort to provide SSI capabilities in a production ready app.
Apache License 2.0
153 stars 149 forks source link

feat: Added a Notification head bar to present current notifications number #1322

Open jian4on opened 1 week ago

jian4on commented 1 week ago

Summary of Changes

Improved the HomeHeaderView component by adding a Notifications head bar, and maintained the test suits for new changes

Related Issues

N/A

Pull Request Checklist

Tick all boxes below to demonstrate that you have completed the respective task. If the item does not apply to your this PR check it anyway to make it apparent that there's nothing to do.

If you have any questions to any of the points above, just submit and ask! This checklist is here to help you, not to deter you from contributing!

Pro Tip 🤓

PR template adapted from the Python attrs project.

sonarcloud[bot] commented 5 days ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

knguyenBC commented 4 days ago

Can the head bar be toggleable/Is it toggleable on/off?

jian4on commented 3 days ago

Can the head bar be toggleable/Is it toggleable on/off?

No interaction control to toggle the notification numbers head bar, but it will disappear after all notifications are dismissed. So we can say it is toggled by current notifications list. Thanks @knguyenBC We do have a chevron toggle icon in this head bar in next story, they are used to toggle the notifications list below and the default Home screen, not for itself.