openwallet-foundation / bifold-wallet

Aries Mobile Agent React Native - Part of the Aries Bifold effort to provide SSI capabilities in a production ready app.
Apache License 2.0
153 stars 149 forks source link

PIN enter screen/component display message is not always aligned with the context #1329

Open timbl-ont opened 3 days ago

timbl-ont commented 3 days ago

Description of problem

A PIN is required in multiple different contexts - e.g., login to the app, change PIN, screen lockout, update biometrics etc..

Each context requires a custom display message to explain the reason for the PIN screen.

Currently, the PIN screen required to change biometric settings displays the screen inactivity lock message.

Longer term the PIN enter functionality should be refactored to create a component that is more flexible. There will likely be other contexts such as proof of presence.

Expected behavior

When entering a PIN to change biometrics settings the PIN screen should display an appropriate text message. For example, "Enter your PIN to complete this change" or something like that.

Steps to reproduce

  1. Log into the wallet
  2. Go to settings --> App Settings (Biometrics)
  3. Toggle the current PIN setting
  4. The PIN screen is displayed with the screen with the inactivity lock message.

Screenshots and/or log output

Environment

Build #:

Android Device Model:

iOS Device Model:

Workaround

Severity