openwallet-foundation / bifold-wallet

Aries Mobile Agent React Native - Part of the Aries Bifold effort to provide SSI capabilities in a production ready app.
Apache License 2.0
146 stars 141 forks source link

Invalid Presentation response for non-revoked credential presentation request #185

Closed cvarjao closed 2 years ago

cvarjao commented 2 years ago

I am running the Faber/Alice demo, and I've noticed the following error in the Faber (Verifier) side:

Faber      | 2022-01-26 17:41:30,921 aries_cloudagent.indy.sdk.verifier ERROR Presentation on nonce=1148054146620911000829177 cannot be validated: Timestamp on sub-proof #0 is missing vs. requested attribute 0_degree_uuid

After some digging, and comparing the presentation response from other wallets, I've noticed that BiFold is missing the timestamp under the identifiers attributes.

BiFold:

"identifiers": [
    {
        "schema_id": "4KeRjcwwRgEMWyWG3g5Fhz:2:degree schema:91.65.51",
        "cred_def_id": "4KeRjcwwRgEMWyWG3g5Fhz:3:CL:141201:faber.agent.degree_schema",
        "rev_reg_id": "4KeRjcwwRgEMWyWG3g5Fhz:4:4KeRjcwwRgEMWyWG3g5Fhz:3:CL:141201:faber.agent.degree_schema:CL_ACCUM:b7eaefc4-8f2d-4278-9dec-a74dcf478c25"
    }
]

From another wallet app:

"identifiers": [
    {
        "schema_id": "4KeRjcwwRgEMWyWG3g5Fhz:2:degree schema:91.65.51",
        "cred_def_id": "4KeRjcwwRgEMWyWG3g5Fhz:3:CL:141201:faber.agent.degree_schema",
        "rev_reg_id": "4KeRjcwwRgEMWyWG3g5Fhz:4:4KeRjcwwRgEMWyWG3g5Fhz:3:CL:141201:faber.agent.degree_schema:CL_ACCUM:b7eaefc4-8f2d-4278-9dec-a74dcf478c25",
        "timestamp": 1643220379
    }
]
cvarjao commented 2 years ago

Being implement in https://github.com/hyperledger/aries-framework-javascript/pull/592