openwallet-foundation / bifold-wallet

Aries Mobile Agent React Native - Part of the Aries Bifold effort to provide SSI capabilities in a production ready app.
Apache License 2.0
136 stars 133 forks source link

[Scan > Allow camera use] Empty screen is displayed if the user does not allow camera usage after tapping the Scan button from the Credentials list #914

Closed AlexanderShenshin closed 9 months ago

AlexanderShenshin commented 11 months ago

Description of problem

There is an empty screen that appears if the user does not allow camera usage after tapping the Scan button from the Credentials list.

Expected behavior

Previous screen (Credentails list) is open.

Steps to reproduce

Precondition: Do not allow the app to use camera.

Environment

Build #: https://github.com/hyperledger/aries-mobile-agent-react-native/tree/db3f18af25f554cd5d616e977e08551b77791c09

Android Device Model: Pixel 4a / Android 11

iOS Device Model: iPhone 12mini / iOS 16.4.1(a)

Workaround

Go back using OS buttons or swipe.

Severity

jp0707 commented 11 months ago

I am looking into this and would like to raise a PR soon. cc: @amanji , @jleach

jleach commented 11 months ago

I am looking into this and would like to raise a PR soon.

🙏

jp0707 commented 11 months ago

PR for this fix - https://github.com/hyperledger/aries-mobile-agent-react-native/pull/942 cc: @amanji , @jleach

amanji commented 11 months ago

Quick turnaround. Great work!

jp0707 commented 10 months ago

We can close this issue.